Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent-count attribute to agent-pool object. #617

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

brandonc
Copy link
Collaborator

Description

Adds the agent-count attribute to the AgentPool struct. Related: hashicorp/terraform-docs-common#224

Testing plan

Apologies I do not have access to a TFE instance or a licensed TFCB org where I am able to run the tests.

External links

Output from tests


@brandonc brandonc requested a review from a team as a code owner December 13, 2022 22:27
@brandonc brandonc force-pushed the brandonc/agent_pool_add_agent_count branch from d280ce7 to ab52cfc Compare December 14, 2022 21:20
@@ -8,6 +8,8 @@
* Adds `List()` method to `GPGKeys` interface by @sebasslash [#602](https://github.com/hashicorp/go-tfe/pull/602)
* Adds `ProviderBinaryUploaded` field to `RegistryPlatforms` struct by @sebasslash [#602](https://github.com/hashicorp/go-tfe/pull/602)

* Adds agent-count to `AgentPools` endpoint. @evilensky [#611](https://github.com/hashicorp/go-tfe/pull/611)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Suggested change
* Adds agent-count to `AgentPools` endpoint. @evilensky [#611](https://github.com/hashicorp/go-tfe/pull/611)
* Adds agent-count to `AgentPools` endpoint by @evilensky [#611](https://github.com/hashicorp/go-tfe/pull/611)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revise this when I make final changes to the CHANGELOG. Thanks!

Copy link
Contributor

@annawinkler annawinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brandonc brandonc merged commit 228640a into main Dec 14, 2022
@brandonc brandonc deleted the brandonc/agent_pool_add_agent_count branch December 14, 2022 23:10
@github-actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants