-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for Run Tasks API changes #390
Conversation
This commit adds the beta API changes for the Run Tasks entitlement as per RFC TF-479: * Add run-tasks to Organization entitlement set This commit also adds tests for this beta feature.
@@ -4,6 +4,7 @@ | |||
|
|||
* Adds support for reading current state version outputs to StateVersionOutputs, which can be useful for reading outputs when users don't have the necessary permissions to read the entire state. | |||
* Adds Variable Set methods for `ApplyToWorkspaces` and `RemoveFromWorkspaces` [#375](https://github.com/hashicorp/go-tfe/pull/375) | |||
* Adds Run Tasks API support by @glennsarti [#381](https://github.com/hashicorp/go-tfe/pull/381), [#382](https://github.com/hashicorp/go-tfe/pull/382) and [#383](https://github.com/hashicorp/go-tfe/pull/383) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split this entry into 3 for each run task change you made:
* Add Run Task permissions field to `Organization` and `Workspace` by @glennsarti [#383](https://github.com/hashicorp/go-tfe/pull/383)
* Add Run Task field to `Entitlement` struct [#381](https://github.com/hashicorp/go-tfe/pull/381)
* Add `Enabled` field to `RunTask` struct [#382](https://github.com/hashicorp/go-tfe/pull/382)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't previously mentioned run tasks at all in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be OK to just say "Run tasks!" and I'm in favor of keeping the original version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's listed in v0.26.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I was only looking in CHANGELOG. You're right. We did label it "beta" so this is still fine, I guess.
Requested changes have been rendered moot :)
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Blocked on #381 being merged first
Changelog Update for the work on Run Tasks API
Description
Changelog update