update changelog, reverse conditional order

hashicorp · Oct 17, 2024 · c3e48c4 · c3e48c4
1 parent ed36a7a
commit c3e48c4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Unreleased
 
+## Enhancements
+
+* Add support for reading a registry module by its unique identifier by @dsa0x
+ [#988](https://github.com/hashicorp/go-tfe/pull/988)
+
 # v1.68.0
 
 ## Enhancements

diff --git a/registry_module.go b/registry_module.go
@@ -527,9 +527,7 @@ func (r *registryModules) Read(ctx context.Context, moduleID RegistryModuleID) (
 	}
 
 	var u string
-	if moduleID.ExternalID != "" {
-		u = fmt.Sprintf("registry-modules/%s", url.PathEscape(moduleID.ExternalID))
-	} else {
+	if moduleID.ExternalID == "" {
 		if moduleID.RegistryName == "" {
 			log.Println("[WARN] Support for using the RegistryModuleID without RegistryName is deprecated as of release 1.5.0 and may be removed in a future version. The preferred method is to include the RegistryName in RegistryModuleID.")
 			moduleID.RegistryName = PrivateRegistry
@@ -548,6 +546,8 @@ func (r *registryModules) Read(ctx context.Context, moduleID RegistryModuleID) (
 			url.PathEscape(moduleID.Name),
 			url.PathEscape(moduleID.Provider),
 		)
+	} else {
+		u = fmt.Sprintf("registry-modules/%s", url.PathEscape(moduleID.ExternalID))
 	}
 
 	req, err := r.client.NewRequest("GET", u, nil)