Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(treeset,iter): use context to control iterate(#52) #53

Merged
merged 1 commit into from
May 1, 2023
Merged

fix(treeset,iter): use context to control iterate(#52) #53

merged 1 commit into from
May 1, 2023

Conversation

zonewave
Copy link
Contributor

@zonewave zonewave commented Apr 30, 2023 •
edited by shoenig
Loading

  1. use goleak
  2. treeset, infix: add bool return param, to control the traversal of the tree
  3. iterate: add context

Closes #52

fix(treeset,iter): use context to control iterate(hashicorp#52)
ee85e84 
1. use goleak
2. infix: add bool to return param of visit
3, iterate: add context to control
@shoenig shoenig added the bug Something isn't working label May 1, 2023
shoenig
shoenig approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks again @zonewave!

@shoenig shoenig merged commit 76643d5 into hashicorp:main May 1, 2023
@zonewave zonewave deleted the feat_iter branch May 10, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoenig shoenig shoenig approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iterator method of treeSet has goroutine leaks
2 participants
@zonewave @shoenig