Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redacted URL in logs / errors #158

Merged
merged 4 commits into from
May 30, 2024

Conversation

dany74q
Copy link
Contributor

@dany74q dany74q commented Mar 15, 2022

So that basic auth creds, if any, won't show up in logs

danehammer and others added 2 commits March 16, 2022 01:53
So that basic auth creds, if any, won't show up in logs
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

.circleci/config.yml Outdated Show resolved Hide resolved
@manicminer manicminer requested a review from a team as a code owner May 30, 2024 00:04
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this fix @dany74q, this LGTM 👍

@manicminer manicminer added this to the v0.7.7 milestone May 30, 2024
@manicminer manicminer merged commit a99f07b into hashicorp:main May 30, 2024
4 checks passed
@eastebry
Copy link

Hey @dany74q - we've decided to retroactively issue a CVE for this issue. If you would like credit for the discovery or fix, please email security[at]hashicorp.com with the name/identifier you would like us to use (Github user dany74q, Dany from SomeCompany, etc.) An acknowledgement will be included in a security bulletin published to https://discuss.hashicorp.com/c/security/

Thank you again!

danishprakash pushed a commit to SUSE/podman that referenced this pull request Oct 1, 2024
This is hashicorp/go-retryablehttp#158 only directly
applied to the vendor/ source tree
See also GHSA-v6v8-xj6m-xwqh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants