Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document correct usage of a ResultIterator #85

Closed
wants to merge 1 commit into from
Closed

Document correct usage of a ResultIterator #85

wants to merge 1 commit into from

Commits on Jan 21, 2021

  1. Document correct usage of a ResultIterator 

    We receicently had [a panic in Consul](hashicorp/consul#9566)
that was caused by incorrect usage of a ResultIterator. A minimal
reproduction of this panic can be seen [here](https://github.com/hashicorp/go-memdb/compare/panic-delete-inside-iter).

Many of us learned that there are undocumented rules for using a
ResultIterator correct with a write transaction.

This commit attempts to document that safe use of a ResultIterator.
    @dnephin
    dnephin committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    555a236 View commit details
    Browse the repository at this point in the history