Adjust runtime caller offset if necessary #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regex to check if caller is inside a logger implemenation file
drewbailey
commented
Oct 25, 2019
| @@ -133,7 +133,7 @@ func TestLogger(t *testing.T) { | |||
| rest := str[dataIdx+1:] | |||
|
|
|||
| // This test will break if you move this around, it's line dependent, just fyi | |||
| assert.Equal(t, "[INFO] go-hclog/logger_test.go:146: test: this is test: who=programmer why=\"testing is fun\"\n", rest) | |||
| assert.Equal(t, "[INFO] go-hclog/logger_test.go:129: test: this is test: who=programmer why=\"testing is fun\"\n", rest) | |||
There was a problem hiding this comment.
the calling loc here seems to be 129 here so not sure why it was 146 earlier https://github.com/hashicorp/go-hclog/pull/51/files#diff-0d02175655a9ca1a852edb40e80012b1R129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First check if initial offset is inside a logger implementation file (interceptlogger.go, intlogger.go) if it is, increase the offset by 1