Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"context"
"errors"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strconv"
Expand Down Expand Up @@ -205,7 +204,7 @@ func (c *Client) Get() error {
if decompressor != nil {
// Create a temporary directory to store our archive. We delete
// this at the end of everything.
td, err := ioutil.TempDir("", "getter")
td, err := os.MkdirTemp("", "getter")
if err != nil {
return fmt.Errorf(
"Error creating temporary directory for archive: %s", err)
Expand Down
4 changes: 2 additions & 2 deletions common.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
package getter

import (
"io/ioutil"
"os"
)

func tmpFile(dir, pattern string) (string, error) {
f, err := ioutil.TempFile(dir, pattern)
f, err := os.CreateTemp(dir, pattern)
if err != nil {
return "", err
}
Expand Down
15 changes: 4 additions & 11 deletions decompress_tar_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package getter
import (
"archive/tar"
"bytes"
"io/ioutil"
"os"
"path/filepath"
"runtime"
Expand Down Expand Up @@ -82,14 +81,11 @@ func TestTarLimits(t *testing.T) {
t.Fatal(err)
}

td, err := ioutil.TempDir("", "getter")
if err != nil {
t.Fatalf("err: %s", err)
}
td := t.TempDir()

tarFilePath := filepath.Join(td, "input.tar")

err = os.WriteFile(tarFilePath, b.Bytes(), 0666)
err := os.WriteFile(tarFilePath, b.Bytes(), 0666)
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down Expand Up @@ -133,15 +129,12 @@ func TestTarLimits(t *testing.T) {

// testDecompressPermissions decompresses a directory and checks the permissions of the expanded files
func testDecompressorPermissions(t *testing.T, d Decompressor, input string, expected map[string]int, umask os.FileMode) {
td, err := ioutil.TempDir("", "getter")
if err != nil {
t.Fatalf("err: %s", err)
}
td := t.TempDir()

// Destination is always joining result so that we have a new path
dst := filepath.Join(td, "subdir", "result")

err = d.Decompress(dst, input, true, umask)
err := d.Decompress(dst, input, true, umask)
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down
3 changes: 1 addition & 2 deletions decompress_testing.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"crypto/md5"
"encoding/hex"
"io"
"io/ioutil"
"os"
"path/filepath"
"reflect"
Expand Down Expand Up @@ -36,7 +35,7 @@ func TestDecompressor(t testing.TB, d Decompressor, cases []TestDecompressCase)
t.Logf("Testing: %s", tc.Input)

// Temporary dir to store stuff
td, err := ioutil.TempDir("", "getter")
td, err := os.MkdirTemp("", "getter")
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down
8 changes: 2 additions & 6 deletions decompress_zip_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package getter
import (
"archive/zip"
"bytes"
"io/ioutil"
"log"
"os"
"path/filepath"
Expand Down Expand Up @@ -169,14 +168,11 @@ func TestDecompressZipBomb(t *testing.T) {
}
}

td, err := ioutil.TempDir("", "go-getter-zip")
if err != nil {
t.Fatalf("err: %s", err)
}
td := t.TempDir()

zipFilePath := filepath.Join(td, "input.zip")

err = os.WriteFile(zipFilePath, buf.Bytes(), 0666)
err := os.WriteFile(zipFilePath, buf.Bytes(), 0666)
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down
8 changes: 2 additions & 6 deletions detect_file_unix_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
package getter

import (
"io/ioutil"
"os"
"path/filepath"
"testing"
Expand All @@ -16,16 +15,13 @@ import (
// If a relative symlink is passed in as the pwd to Detect, the resulting URL
// can have an invalid path.
func TestFileDetector_relativeSymlink(t *testing.T) {
tmpDir, err := ioutil.TempDir("", "go-getter")
if err != nil {
t.Fatal(err)
}
tmpDir := t.TempDir()

defer func() { _ = os.RemoveAll(tmpDir) }()

// We may have a symlinked tmp dir,
// e.g. OSX uses /var -> /private/var
tmpDir, err = filepath.EvalSymlinks(tmpDir)
tmpDir, err := filepath.EvalSymlinks(tmpDir)
if err != nil {
t.Fatal(err)
}
Expand Down
5 changes: 2 additions & 3 deletions get_gcs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
package getter

import (
"io/ioutil"
"net/url"
"os"
"path/filepath"
Expand Down Expand Up @@ -86,7 +85,7 @@ func TestGCSGetter_GetGenerationFile(t *testing.T) {
}

// Verify contents are valid for this generation
content, err := ioutil.ReadFile(dst)
content, err := os.ReadFile(dst)
if err != nil {
t.Fatalf("err: %s", err)
}
Expand All @@ -102,7 +101,7 @@ func TestGCSGetter_GetGenerationFile(t *testing.T) {
}

// Verify contents are valid for this generation
content, err = ioutil.ReadFile(dst)
content, err = os.ReadFile(dst)
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down
3 changes: 1 addition & 2 deletions get_git.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"context"
"encoding/base64"
"fmt"
"io/ioutil"
"net/url"
"os"
"os/exec"
Expand Down Expand Up @@ -101,7 +100,7 @@ func (g *GitGetter) Get(dst string, u *url.URL) error {
}

// Create a temp file for the key and ensure it is removed.
fh, err := ioutil.TempFile("", "go-getter")
fh, err := os.CreateTemp("", "go-getter")
if err != nil {
return err
}
Expand Down
17 changes: 5 additions & 12 deletions get_git_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"encoding/base64"
"errors"
"fmt"
"io/ioutil"
"net/url"
"os"
"os/exec"
Expand Down Expand Up @@ -421,14 +420,11 @@ func TestGitGetter_gitVersion(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("skipping on windows since the test requires sh")
}
dir, err := ioutil.TempDir("", "go-getter")
if err != nil {
t.Fatal(err)
}
dir := t.TempDir()
defer func() { _ = os.RemoveAll(dir) }()

script := filepath.Join(dir, "git")
err = ioutil.WriteFile(
err := os.WriteFile(
script,
[]byte("#!/bin/sh\necho \"git version 2.0 (Some Metadata Here)\n\""),
0700)
Expand Down Expand Up @@ -734,7 +730,7 @@ func TestGitGetter_subdirectory_symlink(t *testing.T) {
g := new(GitGetter)
dst := tempDir(t)

target, err := ioutil.TempFile("", "link-target")
target, err := os.CreateTemp("", "link-target")
if err != nil {
t.Fatal(err)
}
Expand Down Expand Up @@ -1028,10 +1024,7 @@ type gitRepo struct {

// testGitRepo creates a new test git repository.
func testGitRepo(t *testing.T, name string) *gitRepo {
dir, err := ioutil.TempDir("", "go-getter")
if err != nil {
t.Fatal(err)
}
dir := t.TempDir()
dir = filepath.Join(dir, name)
if err := os.Mkdir(dir, 0700); err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -1070,7 +1063,7 @@ func (r *gitRepo) git(args ...string) {
// commitFile writes and commits a text file to the repo.
func (r *gitRepo) commitFile(file, content string) {
path := filepath.Join(r.dir, file)
if err := ioutil.WriteFile(path, []byte(content), 0600); err != nil {
if err := os.WriteFile(path, []byte(content), 0600); err != nil {
r.t.Fatal(err)
}
r.git("add", file)
Expand Down
14 changes: 5 additions & 9 deletions get_http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"encoding/hex"
"errors"
"fmt"
"io/ioutil"
"net"
"net/http"
"net/http/httputil"
Expand Down Expand Up @@ -253,7 +252,7 @@ func TestHttpGetter_resume(t *testing.T) {
t.Fatalf("finishing download should not error: %v", err)
}

b, err := ioutil.ReadFile(dst)
b, err := os.ReadFile(dst)
if err != nil {
t.Fatalf("readfile failed: %v", err)
}
Expand Down Expand Up @@ -309,7 +308,7 @@ func TestHttpGetter_resumeNoRange(t *testing.T) {
t.Fatalf("finishing download should not error: %v", err)
}

b, err := ioutil.ReadFile(dst)
b, err := os.ReadFile(dst)
if err != nil {
t.Fatalf("readfile failed: %v", err)
}
Expand Down Expand Up @@ -761,10 +760,7 @@ func TestHttpGetter_subdirLink(t *testing.T) {
defer func() { _ = ln.Close() }()

httpGetter := new(HttpGetter)
dst, err := ioutil.TempDir("", "tf")
if err != nil {
t.Fatalf("err: %s", err)
}
dst := t.TempDir()

t.Logf("dst: %q", dst)

Expand All @@ -784,7 +780,7 @@ func TestHttpGetter_subdirLink(t *testing.T) {
},
}

err = client.Get()
err := client.Get()
if err != nil {
t.Fatalf("get err: %v", err)
}
Expand Down Expand Up @@ -829,7 +825,7 @@ func testHttpServerWithXTerraformGetDetected(t *testing.T) net.Listener {
w.Header().Set("X-Terraform-Get", first)
})
mux.HandleFunc("/archive.tar.gz", func(w http.ResponseWriter, r *http.Request) {
f, err := ioutil.ReadFile("testdata/archive.tar.gz")
f, err := os.ReadFile("testdata/archive.tar.gz")
if err != nil {
t.Fatal(err)
}
Expand Down
5 changes: 2 additions & 3 deletions module_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
package getter

import (
"io/ioutil"
"net/http"
"net/http/httptest"
"net/url"
Expand All @@ -19,7 +18,7 @@ import (
const fixtureDir = "./testdata"

func tempDir(t *testing.T) string {
dir, err := ioutil.TempDir("", "tf")
dir, err := os.MkdirTemp("", "tf")
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down Expand Up @@ -77,7 +76,7 @@ func testURL(s string) *url.URL {
}

func assertContents(t *testing.T, path string, contents string) {
data, err := ioutil.ReadFile(path)
data, err := os.ReadFile(path)
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down
6 changes: 1 addition & 5 deletions source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
package getter

import (
"io/ioutil"
"os"
"path/filepath"
"testing"
Expand Down Expand Up @@ -57,10 +56,7 @@ func TestSourceDirSubdir(t *testing.T) {
}

func TestSourceSubdirGlob(t *testing.T) {
td, err := ioutil.TempDir("", "subdir-glob")
if err != nil {
t.Fatal(err)
}
td := t.TempDir()
defer func() { _ = os.RemoveAll(td) }()

if err := os.Mkdir(filepath.Join(td, "subdir"), 0755); err != nil {
Expand Down
3 changes: 1 addition & 2 deletions util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package getter

import (
"io"
"io/ioutil"
"os"
"strings"
"testing"
Expand All @@ -32,7 +31,7 @@ func tempEnv(t *testing.T, k, v string) func() {
// tempFileContents writes a temporary file and returns the path and a function
// to clean it up.
func tempFileContents(t *testing.T, contents string) (string, func()) {
tf, err := ioutil.TempFile("", "getter")
tf, err := os.CreateTemp("", "getter")
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down