Skip to content

add zstd support #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

add zstd support #292

merged 1 commit into from
Nov 17, 2020

Conversation

@yaroot
Copy link
Contributor

@yaroot yaroot commented Nov 5, 2020

It's pretty straightforward and I went with the pure go implementation.

closes #270

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jboero
Copy link

jboero commented Nov 16, 2020

Wow fantastic. I just came back today to throw this together but you've already done it. Thank you!

@jboero
Copy link

jboero commented Nov 16, 2020

@yaroot
Is this single threaded or does it support parallel zstd?

@yaroot
Copy link
Contributor Author

yaroot commented Nov 16, 2020

Is this single threaded or does it support parallel zstd?

It's single threaded

@jboero
Copy link

jboero commented Nov 16, 2020

@schmichael Can we please get this in? Very exciting. Thanks.

@schmichael
Copy link
Member

schmichael commented Nov 17, 2020

Thanks @yaroot !

@schmichael schmichael merged commit 2c34c2a into hashicorp:main Nov 17, 2020
@yaroot yaroot deleted the zstd branch November 18, 2020 01:12
@jboero jboero mentioned this pull request Feb 10, 2021
Open
@jboero jboero mentioned this pull request Jun 9, 2021
Closed
@mark-rushakoff mark-rushakoff mentioned this pull request Feb 2, 2023
Open
nywilken pushed a commit that referenced this pull request Feb 9, 2023
@yaroot @nywilken
Add zstd support
40387a9 
Port changes from v1 #292
nywilken added a commit that referenced this pull request Feb 10, 2023
@nywilken @yaroot
Port Decompression bomb security changes from v1 (#414)
017a2ee 
* Add zstd support

Port changes from v1 #292

* Port decompression bomb changes from v1

#412

---------

Co-authored-by: Yan Su <tsu@yaroot.net>
Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@schmichael schmichael schmichael approved these changes

@azr azr azr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support zstd

5 participants

@yaroot @hashicorp-cla @jboero @schmichael @azr