Skip to content

[Project Solar / Phase 1 / Migration] Table & AdvancedTable carbonization#3988

Open
shleewhite wants to merge 19 commits into
project-solar/phase-1-main-feature-branchfrom
project-solar/phase-1/shleewhite/table-carbonization
Open

[Project Solar / Phase 1 / Migration] Table & AdvancedTable carbonization#3988
shleewhite wants to merge 19 commits into
project-solar/phase-1-main-feature-branchfrom
project-solar/phase-1/shleewhite/table-carbonization

Conversation

@shleewhite

@shleewhite shleewhite commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

If merged, this PR would carbonize the Table component and adds the relevant component tokens. It also adds a new state for the row that toggles the isSelected class.

Note: for reorderable columns, the HTML element to show the preview column as you're dragging is appended to the DOM so it doesn't show as themed on the carbonization page. To validate that it works correctly, check the normal AdvancedTable showcase page and change the theme.

:copilot: Copilot instructions

Read through similar carbonization pages under showcase/app/components/page-carbonization and compare those to the changes made here to ensure this PR aligns with previous carbonization efforts

🔗 External links

Jira ticket: HDS-6104


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jul 17, 2026 7:18pm
hds-website Ready Ready Preview Jul 17, 2026 7:18pm

Request Review

@didoo
didoo force-pushed the project-solar/phase-1/shleewhite/table-carbonization branch from 4396ca7 to 0dce377 Compare July 9, 2026 19:14
@shleewhite
shleewhite requested a review from Copilot July 13, 2026 20:30
@shleewhite shleewhite changed the title [WIP] [Project Solar / Phase 1 / Migration] Table carbonization [Project Solar / Phase 1 / Migration] Table carbonization Jul 13, 2026
@shleewhite
shleewhite marked this pull request as ready for review July 13, 2026 20:47
@shleewhite
shleewhite requested a review from a team as a code owner July 13, 2026 20:47
@didoo

didoo commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@shleewhite I had a quick overview of the PR, and I think is better if you do also the AdvancedTable in the same PR (similar to what Kristin is doing with the form controls), not only to avoid back and forth between decisions but more importantly to have a more holistic view of the carbonization of these two very similar components. What do you think?
I know it's a big ask, given this is your first carbonization, but I think it's still something worth to do it in this way, even if it takes longer.

/cc @alex-ju let me/us know if you disagree with my assessment above

@alex-ju

alex-ju commented Jul 15, 2026

Copy link
Copy Markdown
Member

/cc @alex-ju let me/us know if you disagree with my assessment above

I don’t have strong opinions – if it’s easier for reviewers to compare and contrast both options simultaneously then that would be preferable indeed.

That being said, I see value in seeking early feedback on the Table component first, before replicating some of this work across the AdvancedTable.

@shleewhite shleewhite changed the title [Project Solar / Phase 1 / Migration] Table carbonization [Project Solar / Phase 1 / Migration] Table & AdvancedTable carbonization Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants