[Project Solar / Phase 1 / Migration] Table & AdvancedTable carbonization#3988
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4396ca7 to
0dce377
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@shleewhite I had a quick overview of the PR, and I think is better if you do also the AdvancedTable in the same PR (similar to what Kristin is doing with the form controls), not only to avoid back and forth between decisions but more importantly to have a more holistic view of the carbonization of these two very similar components. What do you think? /cc @alex-ju let me/us know if you disagree with my assessment above |
I don’t have strong opinions – if it’s easier for reviewers to compare and contrast both options simultaneously then that would be preferable indeed. That being said, I see value in seeking early feedback on the Table component first, before replicating some of this work across the AdvancedTable. |
Table & AdvancedTable carbonization
📌 Summary
If merged, this PR would carbonize the
Tablecomponent and adds the relevant component tokens. It also adds a new state for the row that toggles the isSelected class.Note: for reorderable columns, the HTML element to show the preview column as you're dragging is appended to the DOM so it doesn't show as themed on the carbonization page. To validate that it works correctly, check the normal AdvancedTable showcase page and change the theme.
Read through similar carbonization pages under showcase/app/components/page-carbonization and compare those to the changes made here to ensure this PR aligns with previous carbonization efforts
🔗 External links
Jira ticket: HDS-6104
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.