Skip to content

[Spike] reproduce modal close issue#3968

Draft
shleewhite wants to merge 1 commit into
mainfrom
spike-modal-app-frame
Draft

[Spike] reproduce modal close issue#3968
shleewhite wants to merge 1 commit into
mainfrom
spike-modal-app-frame

Conversation

@shleewhite

@shleewhite shleewhite commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

This came up when @pkj-web was using Helios for his project. We noticed that when the Modal wasn't within one of the yielded AppFrame components, it would work but scroll isn't properly restored when it closes. The fix is to either put it within a yielded component (like AF.Main) or to move it outside the AppFrame entirely.

Not sure this is a bug or not and if this is something we should address (I can't think of a time when the Modal would be used in this way in a consumer's app), but thought I would make a reproduction so we can discuss.

To reproduce the issue:


💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jul 2, 2026 3:35pm
hds-website Ready Ready Preview Jul 2, 2026 3:35pm

Request Review

@didoo

didoo commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@shleewhite probably a bug, I see a spurious inline overflow: hidden style still applied to the body element even after the modal has been closed.

screenshot_6682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants