Skip to content

MCP - Add flight-icons resource#3950

Draft
zamoore wants to merge 27 commits into
zamoore/mcp-improvementsfrom
zamoore/HDS-6484/mcp__icons-resource
Draft

MCP - Add flight-icons resource#3950
zamoore wants to merge 27 commits into
zamoore/mcp-improvementsfrom
zamoore/HDS-6484/mcp__icons-resource

Conversation

@zamoore

@zamoore zamoore commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

If merged, this PR adds Flight Icons MCP resources (hds://icons and hds://icons/{iconName}) backed by a new icon catalog store + schema/lookup layer, and registers them in MCP resource bootstrapping.

🛠️ Detailed description

  • Adds packages/mcp/src/resources/flight-icons.ts with:
    • catalog index resource (get_hds_icons)
    • per-icon resource (get_hds_icon)
  • Adds packages/mcp/src/stores/flight-icons/:
    • schema.ts for catalog validation (Zod)
    • lookup.ts for icon record shaping + normalized lookup keys
    • store.ts for loading @hashicorp/flight-icons/catalog.json, metadata, lookup, and filtering/search support
  • Updates packages/mcp/src/resources/index.ts to register Flight Icons resources.

:copilot: Copilot instructions

Focus review on resource contract shape, lookup normalization behavior (icon name + filename), and not-found/error responses.

Jira ticket: HDS-6484


💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jul 16, 2026 11:56pm
hds-website Ready Ready Preview Jul 16, 2026 11:56pm

Request Review

@zamoore
zamoore force-pushed the zamoore/HDS-6484/mcp__icons-resource branch from 013178b to a294c30 Compare July 2, 2026 20:43
@zamoore
zamoore force-pushed the zamoore/HDS-6484/mcp__icons-resource branch from a5a28cb to 29fb0e5 Compare July 6, 2026 14:07
@zamoore
zamoore changed the base branch from main to zamoore/HDS-6487/mcp__resource_infra July 6, 2026 14:08
@zamoore
zamoore force-pushed the zamoore/HDS-6487/mcp__resource_infra branch 5 times, most recently from 249f676 to f28e767 Compare July 7, 2026 14:16
@zamoore
zamoore force-pushed the zamoore/HDS-6484/mcp__icons-resource branch from 29fb0e5 to cf99b08 Compare July 7, 2026 15:03
@zamoore
zamoore force-pushed the zamoore/HDS-6484/mcp__icons-resource branch from cf99b08 to 48a9682 Compare July 7, 2026 15:09
@zamoore
zamoore requested a review from Copilot July 7, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add MCP “flight-icons” resources (hds://icons and hds://icons/{icon}) by introducing a validated in-memory icon catalog store plus JSON resource response helpers.

Changes:

  • Adds a flight-icons catalog loader/store with normalization, lookup, and filtered search helpers.
  • Adds resource readers for icon collection and single-icon payloads, plus JSON response utilities.
  • Updates the lockfile (notably rxjs resolution) and attempts to wire resource registration in the MCP entrypoint.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pnpm-lock.yaml Updates dependency resolutions (e.g., rxjs 7.8.1 → 7.8.2).
packages/mcp/src/utils/resources.ts Adds JSON response + “safe handler” utilities for MCP resource readers.
packages/mcp/src/stores/flight-icons/schema.ts Introduces Zod schemas/types for validating the icon catalog JSON.
packages/mcp/src/stores/flight-icons/lookup.ts Adds normalization + record/variant shaping and lookup-key generation.
packages/mcp/src/stores/flight-icons/store.ts Implements catalog loading, indexing (name/filename), metadata, and search filtering.
packages/mcp/src/resources/flight-icons.ts Defines payload shapes for hds://icons and hds://icons/{icon} resource reads.
packages/mcp/src/index.ts MCP server entrypoint; currently contains unresolved merge-conflict markers around resource registration.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/mcp/src/stores/flight-icons/store.ts
Comment thread packages/mcp/src/stores/flight-icons/store.ts Outdated
Comment thread packages/mcp/src/stores/flight-icons/store.ts Outdated
Comment thread packages/mcp/src/resources/flight-icons.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants