MCP - Add flight-icons resource#3950
Draft
zamoore wants to merge 27 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore
force-pushed
the
zamoore/HDS-6484/mcp__icons-resource
branch
from
July 2, 2026 20:43
013178b to
a294c30
Compare
zamoore
force-pushed
the
zamoore/HDS-6484/mcp__icons-resource
branch
from
July 6, 2026 14:07
a5a28cb to
29fb0e5
Compare
zamoore
changed the base branch from
main
to
zamoore/HDS-6487/mcp__resource_infra
July 6, 2026 14:08
zamoore
force-pushed
the
zamoore/HDS-6487/mcp__resource_infra
branch
5 times, most recently
from
July 7, 2026 14:16
249f676 to
f28e767
Compare
zamoore
force-pushed
the
zamoore/HDS-6484/mcp__icons-resource
branch
from
July 7, 2026 15:03
29fb0e5 to
cf99b08
Compare
zamoore
force-pushed
the
zamoore/HDS-6484/mcp__icons-resource
branch
from
July 7, 2026 15:09
cf99b08 to
48a9682
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add MCP “flight-icons” resources (hds://icons and hds://icons/{icon}) by introducing a validated in-memory icon catalog store plus JSON resource response helpers.
Changes:
- Adds a
flight-iconscatalog loader/store with normalization, lookup, and filtered search helpers. - Adds resource readers for icon collection and single-icon payloads, plus JSON response utilities.
- Updates the lockfile (notably
rxjsresolution) and attempts to wire resource registration in the MCP entrypoint.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Updates dependency resolutions (e.g., rxjs 7.8.1 → 7.8.2). |
packages/mcp/src/utils/resources.ts |
Adds JSON response + “safe handler” utilities for MCP resource readers. |
packages/mcp/src/stores/flight-icons/schema.ts |
Introduces Zod schemas/types for validating the icon catalog JSON. |
packages/mcp/src/stores/flight-icons/lookup.ts |
Adds normalization + record/variant shaping and lookup-key generation. |
packages/mcp/src/stores/flight-icons/store.ts |
Implements catalog loading, indexing (name/filename), metadata, and search filtering. |
packages/mcp/src/resources/flight-icons.ts |
Defines payload shapes for hds://icons and hds://icons/{icon} resource reads. |
packages/mcp/src/index.ts |
MCP server entrypoint; currently contains unresolved merge-conflict markers around resource registration. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
zamoore
force-pushed
the
zamoore/HDS-6484/mcp__icons-resource
branch
from
July 16, 2026 21:33
099bc21 to
ad6eff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds Flight Icons MCP resources (
hds://iconsandhds://icons/{iconName}) backed by a new icon catalog store + schema/lookup layer, and registers them in MCP resource bootstrapping.🛠️ Detailed description
packages/mcp/src/resources/flight-icons.tswith:get_hds_icons)get_hds_icon)packages/mcp/src/stores/flight-icons/:schema.tsfor catalog validation (Zod)lookup.tsfor icon record shaping + normalized lookup keysstore.tsfor loading@hashicorp/flight-icons/catalog.json, metadata, lookup, and filtering/search supportpackages/mcp/src/resources/index.tsto register Flight Icons resources.Focus review on resource contract shape, lookup normalization behavior (icon name + filename), and not-found/error responses.
Jira ticket: HDS-6484
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.