Skip to content

[Project Solar / Phase 1 / Components] LinkInline and LinkStandalone carbonization#3587

Merged
dchyun merged 17 commits into
project-solar/phase-1-main-feature-branchfrom
project-solar/phase-1/dchyun/link-carbonization
Mar 26, 2026
Merged

[Project Solar / Phase 1 / Components] LinkInline and LinkStandalone carbonization#3587
dchyun merged 17 commits into
project-solar/phase-1-main-feature-branchfrom
project-solar/phase-1/dchyun/link-carbonization

Conversation

@dchyun

@dchyun dchyun commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

📌 Summary

This PR carbonizes the LinkInline and LinkStandalone components and adds component tokens for each to the tokens library.

🛠️ Detailed description

LinkInline

Note: The LinkInline component does not contain styling for the typography outside of the color. All styling comes from applying an HDS typography class to the component. Those classes are being migrated in a separate effort as part of the Foundational alignments.

Summary of changes

  • Aligned margin between icon and text
  • Aligned border radius

LinkStandalone

Summary of changes

  • Aligned font size, line height, letter spacing, and icon size for each size variant
  • Aligned colors for hover and active state, as well as removing background for active state
  • Removed transition of color to align to Carbon
  • Updated the foreground.action-active semantic variable value for the Carbon themes to align with how Carbon handles links
    • In HDS the active state color is equal to the hover state, but in Carbon the active state is equal to the default state color
  • Removed the background from the active state styles
    • The HDS component's active state has a background added through a pseudo element. This background is not present on any other states, or in any of the carbon components. For simplicities sake, this background has been removed from the HDS component. A similar change has been made on the Figma side.

Before

Screenshot 2026-02-26 at 2 50 24 PM

After

Screenshot 2026-02-26 at 2 50 33 PM

🔗 External links

Eng Jira ticket: HDS-6036
Design Jira ticket: HDS-5742
Figma file: [if it applies]


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel

vercel Bot commented Feb 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Mar 25, 2026 9:34pm
hds-website Ready Ready Preview Mar 25, 2026 9:34pm

Request Review

Comment thread packages/tokens/src/products/shared/link/standalone.json
Comment thread packages/components/src/styles/components/link/standalone.scss Outdated
Comment thread packages/tokens/src/products/shared/link/standalone.json
Comment thread packages/components/src/styles/components/link/inline.scss Outdated
Comment thread packages/components/src/styles/components/link/standalone.scss Outdated
@didoo didoo changed the title [Project Solar / Phase 1 / Migration] Carbonization of LinkInline and LinkStandalone [Project Solar / Phase 1 / Components] LinkInline and LinkStandalone carbonization Feb 11, 2026
@dchyun
dchyun requested review from a team and jorytindall February 12, 2026 16:45
@didoo
didoo force-pushed the project-solar/phase-1/dchyun/link-carbonization branch from c1bdf66 to c14d981 Compare February 17, 2026 18:47
@didoo
didoo changed the base branch from project-solar/phase-1-main-feature-branch to project-solar/phase-1/HDS-5209/foundations-colors-typography-borders February 17, 2026 18:48
Comment thread packages/components/src/styles/components/link/standalone.scss Outdated
@dchyun
dchyun marked this pull request as ready for review February 18, 2026 19:44
@dchyun
dchyun requested a review from a team as a code owner February 18, 2026 19:44
@didoo
didoo force-pushed the project-solar/phase-1/HDS-5209/foundations-colors-typography-borders branch from f441b95 to 57db64e Compare February 19, 2026 20:06
@dchyun
dchyun force-pushed the project-solar/phase-1/dchyun/link-carbonization branch from 0a0c899 to 570d7e2 Compare February 20, 2026 15:34
@dchyun
dchyun force-pushed the project-solar/phase-1/dchyun/link-carbonization branch from 570d7e2 to ba00bcf Compare February 20, 2026 20:31

@jorytindall jorytindall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added two new outline tokens, link.inline.outline.width and link.inline.outline.color to align the focus state to Carbon.

Everything looks good to me, but even with the new outline tokens it looks like the width is still more than Carbon's (which is just 1px). Understanding that it's a bit of a unique case compared with the rest of the components that use the mixin. Not wanting to continue splitting hairs!

@dchyun

dchyun commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

Everything looks good to me, but even with the new outline tokens it looks like the width is still more than Carbon's (which is just 1px). Understanding that it's a bit of a unique case compared with the rest of the components that use the mixin. Not wanting to continue splitting hairs!

@jorytindall Both the Carbon focus outline and Carbonized focus outline should be 1px. I believe they are fully aligned. Also made one small update to show the text underline on focus for the carbon themes.

Screenshot 2026-03-23 at 9 35 12 AM

@didoo didoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few minor comments, and a general question

Comment thread showcase/app/components/page-carbonization/components/link/inline/index.gts Outdated
Comment thread packages/tokens/src/products/shared/link/standalone.json Outdated
Comment thread packages/components/src/styles/components/link/standalone.scss Outdated
Comment thread packages/components/src/styles/components/link/standalone.scss
@didoo

didoo commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

@dchyun this is not a false positive, it's a possible regression: I've checked comparing your branch with production, and I see a shift in the elements in the page, not sure what is the cause (haven't investigated)
screenshot_6053

Comment thread packages/components/src/styles/components/link/standalone.scss

@didoo didoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants