[Project Solar / Phase 1 / Components] LinkInline and LinkStandalone carbonization#3587
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
LinkInline and LinkStandalone carbonization
c1bdf66 to
c14d981
Compare
f441b95 to
57db64e
Compare
0a0c899 to
570d7e2
Compare
570d7e2 to
ba00bcf
Compare
SQ SQ SQ SQ SQ SQ
bd61130 to
61e05c0
Compare
jorytindall
left a comment
There was a problem hiding this comment.
I've added two new outline tokens, link.inline.outline.width and link.inline.outline.color to align the focus state to Carbon.
Everything looks good to me, but even with the new outline tokens it looks like the width is still more than Carbon's (which is just 1px). Understanding that it's a bit of a unique case compared with the rest of the components that use the mixin. Not wanting to continue splitting hairs!
@jorytindall Both the Carbon focus outline and Carbonized focus outline should be 1px. I believe they are fully aligned. Also made one small update to show the text underline on focus for the carbon themes.
|
didoo
left a comment
There was a problem hiding this comment.
I have left a few minor comments, and a general question
|
@dchyun this is not a false positive, it's a possible regression: I've checked comparing your branch with production, and I see a shift in the elements in the page, not sure what is the cause (haven't investigated) |


📌 Summary
This PR carbonizes the
LinkInlineandLinkStandalonecomponents and adds component tokens for each to the tokens library.🛠️ Detailed description
LinkInline
Note: The
LinkInlinecomponent does not contain styling for the typography outside of the color. All styling comes from applying an HDS typography class to the component. Those classes are being migrated in a separate effort as part of the Foundational alignments.Summary of changes
LinkStandalone
Summary of changes
foreground.action-activesemantic variable value for the Carbon themes to align with how Carbon handles linksBefore
After
🔗 External links
Eng Jira ticket: HDS-6036
Design Jira ticket: HDS-5742
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.