SuperSelect - Fix styling of search results loading message (HDS-5727)
#3439
+87
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… results message styling, add Showcase examples of messages
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Removed incorrect checkbox styling in SuperSelect component.
https://github.com/hashicorp/design-system into kristin/hds-5727-superselec-loading-message-style-bug
KristinLBradley
deleted the
kristin/hds-5727-superselec-loading-message-style-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR removes the styling adding a pseudo checkbox next to the search results loading message and instead styles it similarly to the "no matches" message.
📸 Screenshots
BEFORE (Note: checkbox next to "Loading options..." message)
AFTER (isolated Showcase example w/ checkbox removed)
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.