Website: batch 2 of component gts conversions #3436
+1,675
−1,168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shleewhite
force-pushed
the
website/gts-all-docs-components
branch
from
8083853 to
fac2f05
Compare
shleewhite
force-pushed
the
website/gts-all-docs-components
branch
from
9a4a7bf to
e418f44
Compare
shleewhite
changed the title
added 12 commits
December 15, 2025 16:37
added 19 commits
December 15, 2025 16:37
shleewhite
force-pushed
the
website/gts-all-docs-components
branch
from
75a8177 to
966bcc2
Compare
didoo
previously approved these changes
Dec 16, 2025
Contributor
didoo
left a comment
didoo
left a comment
There was a problem hiding this comment.
Nothing that stood out for me.
Comment on lines
53
to
81
| <img | ||
| class="doc-cards-card__image" | ||
| src={{@image}} | ||
| alt="" | ||
| role="presentation" | ||
| /> | ||
| <div class="doc-cards-card__details"> | ||
| <p class="doc-cards-card__title">{{@title}}</p> | ||
| {{#if @status.deprecated}} | ||
| <DocBadge | ||
| class="doc-cards-card__badge" | ||
| @type="warning-inverted" | ||
| @size="medium" | ||
| >Deprecated</DocBadge> | ||
| {{else if @status.updated}} | ||
| <DocBadge | ||
| class="doc-cards-card__badge" | ||
| @type="neutral-inverted" | ||
| @size="medium" | ||
| >Updated</DocBadge> | ||
| {{else if @status.added}} | ||
| <DocBadge | ||
| class="doc-cards-card__badge" | ||
| @type="information-inverted" | ||
| @size="medium" | ||
| >Added</DocBadge> | ||
| {{/if}} | ||
| <p class="doc-cards-card_description">{{@caption}}</p> | ||
| </div> |
Contributor
There was a problem hiding this comment.
One nice thing of gts files is that one can define local (in the same file) components, to be used inside the main <template> block. In this case, you can abstract away all this part, and avoid the duplication below.
Contributor
Author
There was a problem hiding this comment.
I didnt end up making a sub component, but I did switch to getters so the logic only happens in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would convert another chunk of the website components to gts.
There are still a few more components, but they are more involved so I will split them into their own PR.
🔗 External links
Jira ticket: HDS-5704
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.