Skip to content

Conversation

@KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Dec 9, 2025

Ready to merge after next release.


📌 Summary

If merged, this PR adds documentation for the boundary option for components using hds-anchored-position modifier, including the PopoverPrimitive, Dropdown, and RichTooltip.

Web docs previews:

🔗 External links


👀 Component checklist

  • [ ] Percy was checked for any visual regression
  • [ ] A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Dec 11, 2025 6:38pm
hds-website Ready Ready Preview Dec 11, 2025 6:38pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website showcase labels Dec 9, 2025
@KristinLBradley KristinLBradley changed the base branch from main to kristin/hds-5092-collision-detection-root-boundary-option December 9, 2025 19:10
@KristinLBradley KristinLBradley marked this pull request as ready for review December 10, 2025 22:32
@KristinLBradley KristinLBradley requested review from a team as code owners December 10, 2025 22:32
@KristinLBradley
Copy link
Contributor Author

I documented the API but didn't add code examples since I'm not sure how important/useful the new boundary option is to most consumers. I can add some examples if anyone thinks it would be helpful though. Please let me know what you think.

didoo
didoo previously approved these changes Dec 11, 2025
@didoo
Copy link
Contributor

didoo commented Dec 11, 2025

I documented the API but didn't add code examples since I'm not sure how important/useful the new boundary option is to most consumers. I can add some examples if anyone thinks it would be helpful though. Please let me know what you think.

@KristinLBradley we can always add it later, if we discover is needed (for some realistic use case)

Base automatically changed from kristin/hds-5092-collision-detection-root-boundary-option to main December 11, 2025 17:06
@KristinLBradley KristinLBradley dismissed didoo’s stale review December 11, 2025 17:06

The base branch was changed.

@KristinLBradley KristinLBradley force-pushed the kristin/hds-5092-boundary-option-documentation branch from 2db2c99 to e224ca3 Compare December 11, 2025 18:29
@KristinLBradley
Copy link
Contributor Author

I rebased onto main, could you please re-approve? @didoo

(I won't merge though as this shouldn't go out until the next release.)

@KristinLBradley KristinLBradley requested review from a team and didoo December 11, 2025 18:44
@didoo didoo added this to the 5.2.0 milestone Dec 12, 2025
@KristinLBradley KristinLBradley marked this pull request as draft December 12, 2025 18:23
@KristinLBradley
Copy link
Contributor Author

Converted to draft to avoid accidental merge before next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-website Content updates to the documentation website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants