Skip to content

Add "aap" to Ansible icons keywords #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorytindall merged 2 commits into from
Dec 9, 2025
Merged

Add "aap" to Ansible icons keywords #3430

jorytindall merged 2 commits into from
Dec 9, 2025

Conversation

@hashibot-hds
Copy link
Collaborator

@hashibot-hds hashibot-hds commented Dec 9, 2025 •
edited by jorytindall
Loading

📌 Summary

Adds "aap" (abbreviation for Ansible Automation Platform, similar to aws) to Ansible icons per this thread

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

@vercel
Copy link

vercel bot commented Dec 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Dec 9, 2025 1:05am
hds-website Ready Ready Preview Dec 9, 2025 1:05am

@jorytindall jorytindall changed the title Updated export of icons from Figma Add "aap" to Ansible icons keywords Dec 9, 2025
@jorytindall jorytindall marked this pull request as ready for review December 9, 2025 01:02
@jorytindall jorytindall requested review from a team as code owners December 9, 2025 01:02
didoo
didoo approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why some of the icons have their order redefined, but it should not be an issue.

@jorytindall
Copy link
Contributor

jorytindall commented Dec 9, 2025

Not sure why some of the icons have their order redefined, but it should not be an issue.

@didoo I noticed that as well, but they all seem to be included 🤷‍♂️

@heatherlarsen
Copy link
Contributor

heatherlarsen commented Dec 9, 2025

@didoo @jorytindall Sorry, that was my fault. As I was working on the icon usage list yesterday, I noticed some items weren't in alphabetical order (they should be), so I fixed them. I didn't realize that would change how they came through the pipeline, though. Should I move them back?

@didoo
Copy link
Contributor

didoo commented Dec 9, 2025 •
edited
Loading

@didoo @jorytindall Sorry, that was my fault. As I was working on the icon usage list yesterday, I noticed some items weren't in alphabetical order (they should be), so I fixed them. I didn't realize that would change how they came through the pipeline, though. Should I move them back?

@heatherlarsen no no, it's not a "problem". Just wanted to double check that there were some actual (intentional) changes in the source Figma file. All good then

@jorytindall jorytindall merged commit 9640239 into main Dec 9, 2025
15 checks passed
@jorytindall jorytindall deleted the hds-icon-export-9ddafe9 branch December 9, 2025 20:59
@hashibot-hds hashibot-hds mentioned this pull request Dec 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didoo didoo didoo approved these changes

@evankerrigan evankerrigan Awaiting requested review from evankerrigan

Assignees

No one assigned

Labels

packages/flight-icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hashibot-hds @jorytindall @heatherlarsen @didoo