-
Notifications
You must be signed in to change notification settings - Fork 49
[WIP-07-A] [Project Solar / Phase 1 / Dry-run] Include IBM Plex fonts as part of the @hashicorp/design-system-components package
#3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
didoo
wants to merge
7
commits into
project-solar/phase-1-main-feature-branch
Choose a base branch
from
project-solar/phase-1/HDS-5688/ibm-plex-font-embedding
base: project-solar/phase-1-main-feature-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ec97849
added `@ibm/plex-sans` and `@ibm/plex-mono` as dev-dependencies for `…
didoo f08c49d
update Rollup configuration for `packages/components` to copy static …
didoo 1f3a44d
added custom `design-system-plex-fonts.scss` file to generate `@font-…
didoo cda6a2a
added IBM Plex font files to the `public-assets` entry in the Ember V…
didoo 179fd81
updated scripts in `packages/components/package.json` to handle new `…
didoo e3e971a
removed import of CDN stylesheet for Plex Sans + added import of HDS-…
didoo 73b74a2
updated temporary CSS files (components + themed tokens) in showcase …
didoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
packages/components/src/styles/@hashicorp/design-system-plex-fonts.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /** | ||
| * Copyright (c) HashiCorp, Inc. | ||
| * SPDX-License-Identifier: MPL-2.0 | ||
| */ | ||
|
|
||
| // | ||
| // IBM PLEX FONTS | ||
| // | ||
|
|
||
| // We use only a few selected weights, per design specs | ||
| /* stylelint-disable value-keyword-case */ | ||
| $selected-weights: ( | ||
| // ❌ 100 | ||
| thin: false, | ||
| thinItalic: false, | ||
| // ❌ 200 | ||
| extralight: false, | ||
| extralightItalic: false, | ||
| // ❌ 300 | ||
| light: false, | ||
| lightItalic: false, | ||
| // ✅ 400 | ||
| regular: true, | ||
| italic: true, | ||
| // ❌ 500 | ||
| medium: false, | ||
| mediumItalic: false, | ||
| // ❌ 450 | ||
| text: false, | ||
| textItalic: false, | ||
| // ✅ 600 | ||
| semibold: true, | ||
| semiboldItalic: true, | ||
| // ❌ 700 | ||
| bold: false, | ||
| boldItalic: false | ||
| ); | ||
| /* stylelint-enable value-keyword-case */ | ||
|
|
||
| // Plex Sans (imported from `node_modules/@ibm/plex-sans`) | ||
| // | ||
| @use "plex-sans/scss/index.scss" as PlexSans with ( | ||
| $font-prefix: "/assets", | ||
| $font-weights: $selected-weights | ||
| ); | ||
|
|
||
| // Plex Mono (imported from `node_modules/@ibm/plex-mono`) | ||
| // | ||
| @use "plex-mono/scss/index.scss" as PlexMono with ( | ||
| $font-prefix: "/assets", | ||
| $font-weights: $selected-weights | ||
| ); | ||
|
|
||
| // Add the `@font-face` definitions | ||
| // see: https://github.com/IBM/plex/tree/master/packages/plex-sans#font-weights | ||
| // | ||
| @include PlexSans.all(); | ||
| @include PlexMono.all(); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD if they should be devDependencies or normal dependencies