-
Notifications
You must be signed in to change notification settings - Fork 49
Update ember-power-select, PowerSelectMultiple -> @multiple #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
this potentially breaking, I think to be safe we should target v5 for this change, maybe. |
What do you think is breaking? |
Since there are consumer that BYO version of power select which might be lower then 8.11 where this API has been introduced we might run into issues. Maybe it's worth spinnning up RC build to test out on consumer but given that v5 is around the corner it might be just safer to target major release |
|
|
@RobbieTheWagner to follow up, what would you like the next steps to be for your PR? The HDS team discussed and this would be considered a breaking change for consumers using the older power-select-version and would require testing within consumer repositories to catch any potential issues before release. Would you like us to target the upgrade for next major HDS release sometime next year? Quick searches I tried for related references:
|
📌 Summary
This PR updates ember-power-select to the latest version and migrates from
PowerSelectMultipleto using@multiple, which is the new API for multiple selects andPowerSelectMultipleis deprecated.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-5725
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.