-
Notifications
You must be signed in to change notification settings - Fork 49
[DO NOT MERGE] Debugging acceptance test failure for the AdvancedTable #3298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
command to run to see the failure: `pnpm test:ember -s -f "Acceptance | components/advanced-table”` errors: 1. global failure: Error: ResizeObserver loop completed with undelivered notifications. 2. Promise rejected during "Components/advanced-table page passes automated a11y checks": The page should have no accessibility violations. Violations: - [serious]: All touch targets must be 24px large, or leave sufficient space - Violated 8 times. -
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
didoo
added a commit
that referenced
this pull request
Oct 13, 2025
didoo
added a commit
that referenced
this pull request
Oct 13, 2025
didoo
added a commit
that referenced
this pull request
Oct 13, 2025
didoo
added a commit
that referenced
this pull request
Oct 17, 2025
didoo
added a commit
that referenced
this pull request
Oct 24, 2025
didoo
added a commit
that referenced
this pull request
Oct 24, 2025
didoo
added a commit
that referenced
this pull request
Oct 24, 2025
didoo
added a commit
that referenced
this pull request
Oct 27, 2025
didoo
added a commit
that referenced
this pull request
Oct 27, 2025
didoo
added a commit
that referenced
this pull request
Oct 27, 2025
didoo
added a commit
that referenced
this pull request
Oct 28, 2025
didoo
added a commit
that referenced
this pull request
Oct 28, 2025
didoo
added a commit
that referenced
this pull request
Oct 29, 2025
didoo
added a commit
that referenced
this pull request
Nov 6, 2025
didoo
added a commit
that referenced
this pull request
Nov 7, 2025
didoo
added a commit
that referenced
this pull request
Nov 12, 2025
didoo
added a commit
that referenced
this pull request
Nov 14, 2025
didoo
added a commit
that referenced
this pull request
Nov 17, 2025
didoo
added a commit
that referenced
this pull request
Nov 18, 2025
didoo
added a commit
that referenced
this pull request
Nov 20, 2025
didoo
added a commit
that referenced
this pull request
Nov 20, 2025
didoo
added a commit
that referenced
this pull request
Nov 21, 2025
didoo
added a commit
that referenced
this pull request
Nov 25, 2025
didoo
added a commit
that referenced
this pull request
Nov 25, 2025
didoo
added a commit
that referenced
this pull request
Dec 16, 2025
didoo
added a commit
that referenced
this pull request
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Warning
Do not merge - Test-only PR
📌 Summary
This PR has been opened to help debugging an issue triggered by a different way in which we include the component's CSS file, which in turn triggers a failure for the AdvancedTable acceptance test (which include an accessibility test too)
🛠️ Detailed description
While working on #3240 I started to notice failures in the acceptance test for the AdvancedTable Showcase page. After a long investigation (almost two days, due to the fact that nothing that I was seeing made sense) I was able to narrow down the "problem" to the changes introduced with this test PR: if we don't compile the CSS for the HDS components, but we use it directly via a stylesheet
<link>in theindex.htmlpage, the test fails.But this doesn't make sense: what I have done in this PR is simply:
design-system-components.cssin thepackage/componentsfolder, using thepnpm buildcommandpackages/components/dist/styles/@hashicorp/design-system-components.csstoshowcase/public/assets/styles/@hashicorp/design-system-components.cssso that when the showcase app is built, the CSS file is copied over in thedist/assetsfoldershowcase/app/index.htmlthe CSS file has been copied over, using<link rel="stylesheet" href="{{rootURL}}assets/styles/@hashicorp/design-system-components.css">@use "@hashicorp/design-system-components"line in theshowcase/app/styles/app.scsspnpm test:ember -s -f "Acceptance | components/advanced-table”This triggers the errors:
In theory such change should not trigger such error, if the CSS is the same, which is something I have checked over and over in different ways. In reality, for some reasons, it triggers the error.
At the moment I am not sure what could be, I need input from other the other @hashicorp/hds-engineering devs to see if they may have some ideas.
symptoms
A few symptoms that something fishy is going on here:
Acceptance | Component | hds/alert) the tests are all passing🔗 External links
Jira ticket: n/a