Skip to content

Guard against accessing hdsIntl service after component destruction #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-ju merged 2 commits into from
Dec 8, 2025
Merged

Guard against accessing hdsIntl service after component destruction #3195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38af92e
Guard against accessing `hdsIntl` service after component destruction
alex-ju Sep 17, 2025
0e28b08
Add changelog entry
alex-ju Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/poor-banks-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@hashicorp/design-system-components": patch
---

<!-- START components/table/advanced-table -->

`AdvancedTable` - Guard against accessing `hdsIntl` service after component destruction

<!-- END -->
3 changes: 3 additions & 0 deletions packages/components/src/components/hds/advanced-table/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,9 @@ export default class HdsAdvancedTable extends Component<HdsAdvancedTableSignatur
newOrder,
insertedAt,
}) => {
// Guard against accessing hdsIntl service after component destruction
if (this.isDestroying || this.isDestroyed) return;

const { reorderedMessageText } = this.args;

if (reorderedMessageText !== undefined) {
Expand Down