Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Reduce discovery-chain log errors #8065

Merged
merged 4 commits into from
Jun 10, 2020

Commits on Jun 9, 2020

  1. ui: Reduce discovery-chain log spam

    Currently the only way that the UI can know whether connect is enabled
    or not is whether we get 500 errors from certain endpoints.
    
    One of these endpoints we already use, so aswell as recovering from a
    500 error, we also remember that connect is disabled for the rest of the
    page 'session' (so until the page is refreshed), and make no further
    http requests to the endpoint.
    
    This means that log spam is reduced to only 1 log per page refresh
    instead of 1 log per service navigation.
    
    Longer term we'll need some way to dynamically discover whether connect
    is enabled per datacenter without relying on something that will add
    error logs to consul.
    John Cowen committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    1946b6e View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. ui: Move meshEnablement checking to a dc level

    John Cowen committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f4fd29d View commit details
    Browse the repository at this point in the history
  2. ui: Acceptance tests

    John Cowen committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    5520d70 View commit details
    Browse the repository at this point in the history
  3. ui: Fix up tests

    John Cowen committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    cdbe24c View commit details
    Browse the repository at this point in the history