Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Split splitter names in the discovery-chain #7180

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

johncowen
Copy link
Contributor

Previous to 1.7 splitter names didn't include the namespace name

i.e. 'service-name'

As of 1.7 they now include the namespace

i.e. 'service-name.namespace'

This PR take account of that.

Previous to 1.7 splitter names didn't include the namespace name

i.e. 'service-name'

as of 1.7 they now include the namespace

i.e. 'service-name.namespace'

This commit take account of that
@johncowen johncowen added the theme/ui Anything related to the UI label Jan 30, 2020
@johncowen johncowen requested a review from a team January 30, 2020 18:53
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit a850480 into ui-staging Jan 30, 2020
@johncowen johncowen deleted the feature/ui-split-splitter-names branch January 30, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants