-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining CI failures after Go 1.12.1 Upgrade #5576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like we have a consistently failing tests and some |
It's fine in this case, but generally speaking you don't want to do this. Use |
Thats totally fine by me but why is |
From the help output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in
build-support
have been made by @mkeeler. Plus this change:go mod edit -require github.com/hashicorp/mdns@v1.0.1
to pull in the version that builds forarm64
.