-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Consul is IPv6 compliant #5468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and while I have no doubt that this would fix the issue would there be any way to add some tests for this? Even if CI might have to skip them for not supporting IPv6 I think they would still be a worthwhile addition.
@mkeeler Yes, I am gonna add a few test in next commit |
Ensure that when we format address:port if the address is IPv6, we format it using "[%s]:%d" instead of "%s:%d". This should fix hashicorp#5460
We ensure that `sidecarServiceFromNodeService` default check use the same IP as sidecar.Proxy.LocalServiceAddress If we enforce ipv6 address there, the check will be correct. Added unit test with both IPv4 and IPv6 to ensure the TCP check is correct
… when port is an int
96c321d
to
7a14404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensure that when we format address:port if the address is IPv6, we
format it using "[%s]:%d" instead of "%s:%d".
This should fix #5460