Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NS records and A records for each server. Constructs ns host name… #3353

Merged
merged 14 commits into from
Aug 8, 2017
Merged

Add NS records and A records for each server. Constructs ns host name… #3353

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f9db387
Add NS records and A records for each server. Constructs ns host name…
Aug 2, 2017
794d1af
Removed a copy pasted irrelevant comment, and other code review feedback
Aug 3, 2017
37f75a3
Use sanitized version of node name of server in NS record, and start …
Aug 3, 2017
824fc4e
Unify regex used to identify invalid dns characters
Aug 3, 2017
7ea11c2
dns: provide correct SOA and NS responses
magiconair Aug 4, 2017
f01f17b
Don't add A records for NS requests, because the record being returne…
Aug 4, 2017
76319f7
Added back glue records in NS response, expanded unit test. Also reus…
Aug 4, 2017
7f34dc0
Added test case with IPV6 bind address for NS records, rewrote tests …
Aug 6, 2017
76b2538
dns: drop CNAME for primary name server
magiconair Aug 7, 2017
60608b4
dns: we do not support zone transfers
magiconair Aug 7, 2017
f17bf78
dns: postmaster -> hostmaster
magiconair Aug 7, 2017
8a9653b
dns: keep NS names in consul domain
magiconair Aug 7, 2017
72ae8c8
Go back to using <nodename>.node.dc.consul as the name of the ns reco…
Aug 7, 2017
9fa237d
dns: minor cleanups
magiconair Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dns: drop CNAME for primary name server
  • Loading branch information
@magiconair
magiconair committed Aug 7, 2017
commit 76b2538915cc9528043bbcbee8f2213c2841b842
17 changes: 0 additions & 17 deletions agent/dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,23 +216,6 @@ func (d *DNSServer) handleQuery(resp dns.ResponseWriter, req *dns.Msg) {
m.Answer = append(m.Answer, d.soa())
m.Ns = append(m.Ns, ns...)
m.Extra = append(m.Extra, glue...)

// add CNAMEs for "ns.<domain>" to the Extra
// section to make the MNAME entry in the SOA
// record resolvable
for _, rr := range ns {
cname := &dns.CNAME{
Hdr: dns.RR_Header{
Name: "ns." + d.domain,
Rrtype: dns.TypeCNAME,
Class: dns.ClassINET,
Ttl: uint32(d.config.NodeTTL / time.Second),
},
Target: rr.(*dns.NS).Ns,
}
m.Extra = append(m.Extra, cname)
}

m.SetRcode(req, dns.RcodeSuccess)

case dns.TypeNS:
Expand Down