Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap w/o Glyphicon Halflings (resolves #2485) #2525

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Conversation

brianshumate
Copy link
Member

  • Remove reference to Glyphicon Halflings @fontface
  • Remove unused Glphyicon related classes

- Remove reference to Glyphicon Halflings @fontface
- Remove unused Glphyicon related classes
@brianshumate
Copy link
Member Author

/static/bootstrap.min.js appears to be dynamically generated(?)

@brianshumate brianshumate deleted the jbs-2485 branch November 22, 2016 00:09
@slackpad
Copy link
Contributor

@pearkes might be able to give a little guidance on how we update this

@brianshumate brianshumate restored the jbs-2485 branch November 22, 2016 00:58
@brianshumate brianshumate reopened this Nov 22, 2016
@brianshumate
Copy link
Member Author

brianshumate commented Nov 22, 2016

Sorry about all the noise — I had intended to retry this PR as I was not sure what else needed to be done after updating the bootstrap.min.css to see that no more requests to the fonts were occurring, but I figured out how it works so I'll restore/reopen and perhaps we can proceed.

It looks like doing a make ui builds the UI in a Docker container and also prepares an updated bindata_assetfs.go for the binary using go-bindata-assetfs. Then make dev indeed picks up the updated command/agent/bindata_assetfs.go and the subsequent running binary has no more 500 ISEs from a wget -r. 😸

I am unsure about the updated bindata_assetfs.go as it is in the repository, but should it be committed too?

@slackpad
Copy link
Contributor

Yeah - that'll pick up your changes in the web assets that are built in for -ui. We didn't want to put the Ruby stuff in the normal build path so we check in the generated files. The release build makes sure that we have done this before we build a final release.

@slackpad slackpad merged commit 098864d into master Nov 23, 2016
@slackpad slackpad deleted the jbs-2485 branch November 23, 2016 01:44
slackpad added a commit that referenced this pull request Nov 23, 2016
@slackpad
Copy link
Contributor

Thanks! No more 404s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants