Skip to content

Comments

docs/WAF: failure zones refresh#21545

Merged
krastin merged 12 commits intomainfrom
docs/WAF-73-Failure-Zones
Jul 22, 2024
Merged

docs/WAF: failure zones refresh#21545
krastin merged 12 commits intomainfrom
docs/WAF-73-Failure-Zones

Conversation

@krastin
Copy link
Contributor

@krastin krastin commented Jul 15, 2024

Description

Incorporating some WAF content into the related Consul doc.

Testing & Reproduction steps

N/A

Links

N/A

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@krastin krastin requested a review from a team as a code owner July 15, 2024 14:35
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jul 15, 2024
@krastin krastin added pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Jul 15, 2024
aimeeu
aimeeu approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, and some structure suggestions

danielehc
danielehc approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@danielehc danielehc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for revamping this.

Left a few comments.

The only thing I would add for some of these sections would be an architectural diagram that explains the desired architecture.

i.e.

This would make it easier to follow the failure cases listed as examples

danielehc
danielehc reviewed Jul 17, 2024
View reviewed changes
@krastin @aimeeu @danielehc
Apply suggestions from code review
06ace24 
Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
@krastin @aimeeu
Update improving-consul-resilience.mdx
6a2e448 
Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
@krastin krastin changed the title failure zones initial commit docs/WAF: failure zones refresh Jul 17, 2024
boruszak
boruszak reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style changes and simplifications.

Before merging, we still need:

  1. Dark mode images
  2. Links to tutorials like the redundancy zones tutorial, because they demonstrate these concepts with a practical example.

website/content/docs/architecture/improving-consul-resilience.mdx Outdated

Cluster peering lets you connect two or more independent Consul clusters using mesh gateways, so that services can communicate between non-identical partitions in different datacenters.

![Reference architecture diagram for Consul cluster peering](/img/architecture/cluster-peering-diagram.png)
Copy link
Contributor

@boruszak boruszak Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark mode required

krastin and others added 3 commits July 22, 2024 13:47
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 7, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.16,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 8, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

16 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 9, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 10, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 11, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 12, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 13, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 14, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 15, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 16, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 17, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 18, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 19, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 19, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 20, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 21, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 22, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 23, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

boruszak added a commit that referenced this pull request Aug 23, 2024
@krastin @aimeeu
@danielehc @boruszak
docs/WAF: failure zones refresh (#21545)
7640c2a 
* failure zones initial commit

* Apply suggestions from code review

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>

* Update improving-consul-resilience.mdx

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>

* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

* fix links in article

* fix inline alert render

---------

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
boruszak added a commit that referenced this pull request Aug 23, 2024
@krastin @aimeeu
@danielehc @boruszak
docs/WAF: failure zones refresh (#21545)
f97e8cf 
* failure zones initial commit

* Apply suggestions from code review

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>

* Update improving-consul-resilience.mdx

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>

* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

* fix links in article

* fix inline alert render

---------

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
boruszak added a commit that referenced this pull request Aug 23, 2024
@krastin @aimeeu
@danielehc @boruszak
docs/WAF: failure zones refresh (#21545)
bf50429 
* failure zones initial commit

* Apply suggestions from code review

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>

* Update improving-consul-resilience.mdx

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>

* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

* fix links in article

* fix inline alert render

---------

Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 24, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 25, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 26, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

boruszak added a commit that referenced this pull request Aug 26, 2024
@boruszak @krastin
@aimeeu @danielehc
docs/WAF: failure zones refresh v1.15 manual backport (#21545) (#21653)
7ee99ca 
docs/WAF: failure zones refresh (#21545)

* failure zones initial commit

* Apply suggestions from code review




* Update improving-consul-resilience.mdx



* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review



* fix links in article

* fix inline alert render

---------

Co-authored-by: Krastin Krastev <krastin@hashicorp.com>
Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
boruszak added a commit that referenced this pull request Aug 26, 2024
@boruszak @krastin
@aimeeu @danielehc
docs/WAF: failure zones refresh (#21545) (#21652)
4604261 
* failure zones initial commit

* Apply suggestions from code review




* Update improving-consul-resilience.mdx



* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review



* fix links in article

* fix inline alert render

---------

Co-authored-by: Krastin Krastev <krastin@hashicorp.com>
Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
boruszak added a commit that referenced this pull request Aug 26, 2024
@boruszak @krastin
@aimeeu @danielehc
Manual backport for docs/WAF: failure zones refresh (#21545) (#21651)
e7d651b 
docs/WAF: failure zones refresh (#21545)

* failure zones initial commit

* Apply suggestions from code review




* Update improving-consul-resilience.mdx



* typo

* adding diagrams

* fixing inline bulletpoint image

* adding light and dark diagrams

* Apply suggestions from code review



* fix links in article

* fix inline alert render

---------

Co-authored-by: Krastin Krastev <krastin@hashicorp.com>
Co-authored-by: Aimee Ukasick <aimee.ukasick@hashicorp.com>
Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 27, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Aug 28, 2024

@krastin, a backport is missing for this PR [21545] for versions [1.15,1.17,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielehc danielehc danielehc approved these changes

@boruszak boruszak boruszak left review comments

@aimeeu aimeeu aimeeu approved these changes

+1 more reviewer

@cjobermaier cjobermaier cjobermaier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE or Ent pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@krastin @hc-github-team-consul-core @aimeeu @danielehc @boruszak @cjobermaier