Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compliance: license checker to enforce MPL pre-EOY 2023 no longer necessary #20175

Merged
merged 1 commit into from
Jan 12, 2024
Merged

compliance: license checker to enforce MPL pre-EOY 2023 no longer necessary #20175

merged 1 commit into from
Jan 12, 2024

Conversation

analogue
Copy link
Contributor

Description

Pre EOY-2023, all consul patch releases < 1.17 had to be MPL. Now that we're in 2024, this license checker is no longer necessary and reverts https://hashicorp.atlassian.net/browse/NET-5371

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@analogue analogue added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Jan 11, 2024
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jan 11, 2024
@analogue analogue added the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 11, 2024
dhiaayachi
dhiaayachi approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@analogue analogue merged commit 98dcfaf into main Jan 12, 2024
113 of 117 checks passed
@analogue analogue deleted the spatel/remove-pre-2024-license-checker branch January 12, 2024 15:35
This was referenced Jan 12, 2024
Merged
Merged
Merged
analogue added a commit that referenced this pull request Jan 12, 2024
@analogue
backport MPL license checker removal (PR #20175)
beeea2f
analogue added a commit that referenced this pull request Jan 12, 2024
@hc-github-team-consul-core @analogue
Backport of compliance: license checker to enforce MPL pre-EOY 2023 n…
c7dabc9 
…o longer necessary into release/1.15.x (#20183)

* no-op commit due to failed cherry-picking

* backport MPL license checker removal (PR #20175)

---------

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiaayachi dhiaayachi dhiaayachi approved these changes

@nathancoleman nathancoleman Awaiting requested review from nathancoleman

Assignees
No one assigned
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@analogue @dhiaayachi