Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of ci: Run go mod tidy check on submodules into release/1.15.x #19746

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Backport of ci: Run go mod tidy check on submodules into release/1.15.x #19746

merged 1 commit into from
Nov 27, 2023

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19744 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.

Today, we do not enforce a clean go mod tidy on submodules. This allows for drift and can eventually lead to golangci-lint failures, along with the obvious disadvantage of not having an up-to-date go.mod.

Enforce clean go mod tidy on all go.mod by using our make target rather than the direct root-level command.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/check-go-mod-tidy-submodules/informally-faithful-anchovy branch 2 times, most recently from 50c7d2f to cc12e51 Compare November 27, 2023 21:28
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Nov 27, 2023
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Nov 27, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@zalimeni zalimeni enabled auto-merge (squash) November 27, 2023 21:30
@vercel vercel bot temporarily deployed to Preview – consul November 27, 2023 21:34 Inactive
@zalimeni zalimeni merged commit 218dca1 into release/1.15.x Nov 27, 2023
85 of 86 checks passed
@zalimeni zalimeni deleted the backport/zalimeni/check-go-mod-tidy-submodules/informally-faithful-anchovy branch November 27, 2023 21:42
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@zalimeni zalimeni Awaiting requested review from zalimeni

Assignees

@zalimeni zalimeni

Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @zalimeni