Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Regen expired test certs into release/1.15.x #19477

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Backport of Regen expired test certs into release/1.15.x #19477

merged 1 commit into from
Nov 2, 2023

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19476 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.

Description

=== FAIL: tlsutil TestConfigurator_OutgoingInternalRPCWrapper/VerifyServerHostname_=_false (re-run 3) (0.00s)
    config_test.go:773: 
        	Error Trace:	/home/runner/work/consul/consul/tlsutil/config_test.go:773
        	Error:      	Received unexpected error:
        	            	x509: certificate has expired or is not yet valid: current time 2023-11-02T02:24:15Z is after 2023-11-01T15:17:35Z
        	Test:       	TestConfigurator_OutgoingInternalRPCWrapper/VerifyServerHostname_=_false

Testing & Reproduction steps

Test passes locally.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/fix-expired-test-certs/strongly-modest-badger branch from b22a770 to 5eb7fc2 Compare November 2, 2023 15:25
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/fix-expired-test-certs/strongly-modest-badger branch from feaa1e6 to d8a444d Compare November 2, 2023 15:25
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Nov 2, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul November 2, 2023 15:36 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 9f17bf7 into release/1.15.x Nov 2, 2023
84 of 86 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/spatel/fix-expired-test-certs/strongly-modest-badger branch November 2, 2023 15:43
@jira jira bot mentioned this pull request Dec 1, 2023
Closed
zalimeni pushed a commit that referenced this pull request Feb 27, 2024
@hc-github-team-consul-core @analogue @zalimeni
Backport of Regen expired test certs into release/1.15.x (#19477)
973b312 
backport of commit d399654

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
@zalimeni zalimeni mentioned this pull request Feb 27, 2024
Merged
4 tasks
@dhiaayachi dhiaayachi mentioned this pull request Sep 27, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@analogue analogue Awaiting requested review from analogue

Assignees

@analogue analogue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @analogue