Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of docs: Fix Kubernetes CRD example configs into release/1.15.x #19439

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Backport of docs: Fix Kubernetes CRD example configs into release/1.15.x #19439

merged 1 commit into from
Oct 31, 2023

Conversation

blake
Copy link
Member

@blake blake commented Oct 30, 2023

Description

Fixes configuration examples for several Consul Kubernetes CRDs. The CRDs were missing required fields such as apiVersion, metadata, and spec.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@blake @im2nguyen
docs: Fix Kubernetes CRD example configs (#18878)
5499de1 
Fixes configuration examples for several Consul Kubernetes CRDs. The
CRDs were missing required fields such as `apiVersion`, `metadata`,
and `spec`.

Co-authored-by: Tu Nguyen <im2nguyen@gmail.com>
@blake blake added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry labels Oct 30, 2023
@blake blake self-assigned this Oct 30, 2023
@blake blake requested a review from a team as a code owner October 30, 2023 23:34
@hc-github-team-consul-core
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@dhiaayachi dhiaayachi merged commit 8c7c3cc into release/1.15.x Oct 31, 2023
64 of 67 checks passed
@dhiaayachi dhiaayachi deleted the docs/backport-fix-k8s-crd-example-configs-1.15 branch October 31, 2023 13:03
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

Assignees

@blake blake

Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blake @hc-github-team-consul-core @david-yu @dhiaayachi