Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of increasing unit tests timeout from 10m to 30m into release/1.15.x #19424

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19423 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jmurret
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

CI is failing when a whole test run goes over the default of 10m. This happens mostly with the agent package when the tests are split. and this happens more in enterprise with self hosted runners.

This change is to make it 30m which matches the integration tests setting.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul October 27, 2023 23:44 Inactive
@jmurret jmurret closed this Oct 30, 2023
@zalimeni zalimeni reopened this Nov 9, 2023
@jmurret jmurret closed this Nov 9, 2023
@jmurret jmurret reopened this Nov 9, 2023
@zalimeni zalimeni force-pushed the backport/jm/go-test-timeout/allegedly-wondrous-beagle branch from 5a14333 to 2a420ef Compare November 9, 2023 18:54
@jmurret jmurret closed this Nov 9, 2023
@jmurret jmurret reopened this Nov 9, 2023
@jmurret jmurret marked this pull request as ready for review November 9, 2023 18:56
@jmurret jmurret enabled auto-merge (squash) November 9, 2023 18:56
@jmurret jmurret merged commit e7c5029 into release/1.15.x Nov 9, 2023
104 of 140 checks passed
@jmurret jmurret deleted the backport/jm/go-test-timeout/allegedly-wondrous-beagle branch November 9, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants