Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of build(docker): always publish full and minor version tags for dev images into release/1.16.x #19281

Merged

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19278 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@DanStough
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Always publishing full and minor-only tag versions. This accomplishes two goals:

For long-running release branches, .x, always publish a minor-only tag so that tests use the latest version (e.g. 1.17-dev)
For point release branches, .0, always publish the full version so we can fix this for testing purposes (e.g. 1.17.0)

Links

Similar to hashicorp/consul-dataplane#306


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul October 18, 2023 19:52 Inactive
@DanStough DanStough force-pushed the backport/dans/fix-docker-dev-tag/jointly-loyal-snake branch from 2d64d32 to c910e1e Compare October 18, 2023 20:40
@DanStough DanStough marked this pull request as ready for review October 18, 2023 20:43
@DanStough DanStough requested a review from a team October 18, 2023 20:43
@DanStough DanStough requested a review from a team as a code owner October 18, 2023 20:43
@DanStough DanStough requested review from marianoasselborn and randyhdev and removed request for a team October 18, 2023 20:43
… for dev images into release/1.17.x (#19282)

backport of commit c6bb4a5

Co-authored-by: DanStough <dan.stough@hashicorp.com>
@DanStough DanStough force-pushed the backport/dans/fix-docker-dev-tag/jointly-loyal-snake branch from c910e1e to cf49ef0 Compare October 18, 2023 20:50
@DanStough DanStough merged commit 5b4d0c8 into release/1.16.x Oct 18, 2023
83 checks passed
@DanStough DanStough deleted the backport/dans/fix-docker-dev-tag/jointly-loyal-snake branch October 18, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants