Downgrading node on CI to support v1.15.X #19249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-hut
added
theme/ui
github-actions
bot
added
theme/contributing
4 tasks
Looks like tests are running successfully on node 14! |
WenInCode
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI has been failing for V1.15.X, which isn't good!
We're planning on just downgrading the node version on CI until next quarter when v1.15.X is no longer supported!
We also only want this change on v1.15.X branch, since we don't want to downgrade node for main.
Testing & Reproduction steps
Links
PR Checklist
References