Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix type of datacenter in Service Resolvers Config Entry into release/1.15.x #19012

Merged

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19004 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@absolutelightning
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Datacenter inside Redirect map is of type string. As mentioned here also

Fixes the doc.

Links

https://developer.hashicorp.com/consul/docs/connect/config-entries/service-resolver#redirect-datacenter


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@absolutelightning absolutelightning marked this pull request as ready for review September 27, 2023 01:37
@absolutelightning absolutelightning requested a review from a team as a code owner September 27, 2023 01:37
@absolutelightning absolutelightning enabled auto-merge (squash) September 27, 2023 01:37
@absolutelightning absolutelightning merged commit d0e2e97 into release/1.15.x Sep 27, 2023
46 of 48 checks passed
@absolutelightning absolutelightning deleted the backport/fix-doc/purely-arriving-seagull branch September 27, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants