Backport of peerstream: fix flaky test related to autopilot integration into release/1.15.x #18989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/rboyer/fix-flaky-stream-test/gratefully-sound-elf
branch
from
8272c96
to
2207e29
Compare
github-team-consul-core-pr-approver
approved these changes
Sep 22, 2023
hc-github-team-consul-core
merged commit cbbc740
into
release/1.15.x
85 of 86 checks passed
hc-github-team-consul-core
deleted the
backport/rboyer/fix-flaky-stream-test/gratefully-sound-elf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18979 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
Occasionally a peerstream/subscription test would flake because a handler was called one extra time. This was due to an overly restrictive mock being too sensitive to multiple requests for the same data.
These tests did not need to care about the number of calls, so I've swapped it out with a dummy object instead in all of the relevant tests. Hopefully that removes the flake completely.
Overview of commits