Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-5574] Update Go version to 1.20.8 into release/1.14.x #18761

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #18742 to be assessed for backporting due to the inclusion of the label backport/1.14.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@zalimeni
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This resolves several CVEs:

  • CVE-2023-39320: cmd/go: go.mod toolchain directive allows arbitrary execution
  • CVE-2023-39318: html/template: improper handling of HTML-like comments within script contexts
  • CVE-2023-39319: html/template: improper handling of special tags within script contexts
  • CVE-2023-39321 and CVE-2023-39322: crypto/tls: panic when processing post-handshake message on QUIC connections

Description

Resolves CVEs and brings us up to the latest version of Go.

Testing & Reproduction steps

Tests should continue to pass.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul September 12, 2023 15:46 Inactive
@zalimeni
Copy link
Member

Conflict resolved; missing build job in 1.14.x had to be removed from cherry-pick change.

@zalimeni zalimeni marked this pull request as ready for review September 12, 2023 16:13
@zalimeni zalimeni requested a review from a team September 12, 2023 16:13
@zalimeni zalimeni requested a review from a team as a code owner September 12, 2023 16:13
@zalimeni zalimeni requested review from sarahethompson and jeanneryan and removed request for a team September 12, 2023 16:13
@zalimeni zalimeni enabled auto-merge (squash) September 12, 2023 16:13
@zalimeni zalimeni merged commit 4de1d6b into release/1.14.x Sep 12, 2023
85 checks passed
@zalimeni zalimeni deleted the backport/zalimeni/net-5574-bump-go-1.20.8/vigorously-ace-bear branch September 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants