-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration #18168
Merged
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
00cee32
OTElExporter now uses an EndpointProvider to discover the endpoint
Achooo 77f09b8
OTELSink uses a ConfigProvider to obtain filters and labels configura…
Achooo ff4d85f
improve tests for otel_sink
Achooo 0264d5b
Regex logic is moved into client for a method on the TelemetryConfig …
Achooo f12219a
Create a telemetry_config_provider and update deps to use it
Achooo 8b4bf1d
Fix conversion
Achooo 5b4c997
fix import newline
Achooo 7550818
Add logger to hcp client and move telemetry_config out of the client.…
Achooo 3f1c53d
Add a telemetry_config.go to refactor client.go
Achooo 8dce916
Update deps
Achooo 2313673
update hcp deps test
Achooo 196a4ef
Modify telemetry_config_providers
Achooo 3b031a2
Check for nil filters
Achooo cb869b1
PR review updates
Achooo 38d6bca
Fix comments and move around pieces
Achooo 1feea25
Fix comments
Achooo 0d25ba4
Remove context from client struct
Achooo a58baa7
Moved ctx out of sink struct and fixed filters, added a test
Achooo f3be3ec
Remove named imports, use errors.New if not fformatting
Achooo a353527
Remove HCP dependencies in telemetry package
Achooo de55bf9
Add success metric and move lock only to grab the t.cfgHahs
Achooo eacf20e
Update hash
Achooo 4ed2b74
fix nits
Achooo e3839b3
Create an equals method and add tests
Achooo b867e30
Improve telemetry_config_provider.go tests
Achooo d4b788a
Add race test
Achooo 932633e
Add missing godoc
Achooo 696966f
Remove mock for MetricsClient
Achooo 1d58bf6
Avoid goroutine test panics
Achooo fea50d4
trying to kick CI lint issues by upgrading mod
Achooo bfebfb1
imprve test code and add hasher for testing
Achooo 54eb748
Use structure logging for filters, fix error constants, and default t…
Achooo 9677781
removed hashin and modify logic to simplify
Achooo c23798c
Improve race test and fix PR feedback by removing hash equals and avo…
Achooo 235acac
Ran make go-mod-tidy
Achooo 1ef0795
Use errtypes in the test
Achooo 2e10100
Add changelog
Achooo 952129c
add safety check for exporter endpoint
Achooo b46d5b9
remove require.Contains by using error types, fix structure logging, …
Achooo 7ea6280
Fixed race test to have changing config values
Achooo d3522ee
Send success metric before modifying config
Achooo aaec9a6
Avoid the defer and move the success metric under
Achooo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
removed hashin and modify logic to simplify
- Loading branch information
commit 96777811a1230792070ddf933d7574238751e4ae
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth logging the refresh interval but you decide if it's too noisy.