Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that wrongly trims domains when there is an overlap with DC name 1.15.x #18163

Merged
merged 1 commit into from
Jul 18, 2023

Commits on Jul 17, 2023

  1. Fix a bug that wrongly trims domains when there is an overlap with DC…

    … name (#17160)
    
    * Fix a bug that wrongly trims domains when there is an overlap with DC name
    
    Before this change, when DC name and domain/alt-domain overlap, the domain name incorrectly trimmed from the query.
    
    Example:
    
    Given: datacenter = dc-test, alt-domain = test.consul.
    Querying for "test-node.node.dc-test.consul" will faile, because the
    code was trimming "test.consul" instead of just ".consul"
    
    This change, fixes the issue by adding dot (.) before trimming
    
    * trimDomain: ensure domain trimmed without modyfing original domains
    
    * update changelog
    
    ---------
    
    Co-authored-by: Dhia Ayachi <dhia@hashicorp.com>
    shamil and dhiaayachi committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9423054 View commit details
    Browse the repository at this point in the history