Backport of [API Gateway] Fix trust domain for external peered services in synthesis code into release/1.15.x #17615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2023 22:37
hc-github-team-consul-core
force-pushed
the
backport/net-4399/api-gateway-fix-peer-discoverychain-synthesis/literally-engaged-gator
branch
2 times, most recently
from
fabf898
to
716ce08
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 8, 2023
hc-github-team-consul-core
deleted the
backport/net-4399/api-gateway-fix-peer-discoverychain-synthesis/literally-engaged-gator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17609 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
This bug was found in writing this test on k8s: hashicorp/consul-k8s#2306
I would like to circle around and write an acceptance-level test in core, but think that might likely have to wait a few weeks given some time constraints, and any behavior that this breaks (v. fixing) should already be covered by tests.
Testing & Reproduction steps
Ran k8s acceptance test and would not pass until these changes were introduced.
PR Checklist
Overview of commits