-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of hoststats: add package for collecting host statistics including cpu memory and disk usage into release/1.15.x #17532
Merged
hc-github-team-consul-core
merged 10 commits into
release/1.15.x
from
backport/telemetry/host-stats/mistakenly-champion-piranha
May 31, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/telemetry/host-stats/mistakenly-champion-piranha
branch
from
May 31, 2023 17:36
e948fd2
to
5385903
Compare
hc-github-team-consul-core
force-pushed
the
backport/telemetry/host-stats/mistakenly-champion-piranha
branch
from
May 31, 2023 17:36
5f5ae46
to
c715151
Compare
github-actions
bot
added
theme/config
Relating to Consul Agent configuration, including reloading
theme/internals
Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics
type/docs
Documentation needs to be created/updated/clarified
labels
May 31, 2023
github-team-consul-core-pr-approver
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved Consul Bot automated PR
…akenly-champion-piranha
hc-github-team-consul-core
deleted the
backport/telemetry/host-stats/mistakenly-champion-piranha
branch
May 31, 2023 18:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme/config
Relating to Consul Agent configuration, including reloading
theme/internals
Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics
type/docs
Documentation needs to be created/updated/clarified
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17038 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
This PR adds the ability for Consul to report host statistics through go-metrics. These metrics include cpu utilization by core and in aggregate, system memory usage and disk usage for the disk backing the configured data_dir.
Testing & Reproduction steps
Tests were added to assert cpu utilization calculation is performed accurately. Manual testing was performed on linux and darwin to ensure reported host stats values were accurate.
PR Checklist
Overview of commits