Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CI: do not upload test metrics to datadog on forks into release/1.15.x #17451

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #17448 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jmurret
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Tested that these changes work on PR from fork: #17445

Testing & Reproduction steps

  • create a PR from fork with only docs changes (or anything that does not cause test failures on its own)
  • validate checks run successfully

expected results: go-tests and test-integrations pass.

actual results: both workflows fail when trying to upload test coverage data to DataDog because the DD API key is not present (since the fork does not contain it).

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jm/NET-4178/loosely-accurate-primate branch from 23327f8 to bd05d40 Compare May 24, 2023 18:58
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jm/NET-4178/loosely-accurate-primate branch 2 times, most recently from 338adc6 to bd05d40 Compare May 24, 2023 18:58
@github-actions github-actions bot added theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases labels May 24, 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 24, 2023 19:01 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 24, 2023 19:03 Inactive
* bypass uploading testmetrics to datadog on forks / when api is not available

* add exclusions to upgrade tests
@jmurret jmurret marked this pull request as ready for review May 24, 2023 19:29
@jmurret jmurret enabled auto-merge (squash) May 24, 2023 19:36
@jmurret jmurret merged commit d076d69 into release/1.15.x Jun 12, 2023
@jmurret jmurret deleted the backport/jm/NET-4178/loosely-accurate-primate branch June 12, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants