Backport of Fix multiple issues related to proxycfg health queries. into release/1.15.x #17268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-3881/health-call-loop/especially-tough-lamb
branch
2 times, most recently
from
da37bda
to
345a67d
Compare
github-team-consul-core-pr-approver
approved these changes
May 9, 2023
hc-github-team-consul-core
deleted the
backport/derekm/NET-3881/health-call-loop/especially-tough-lamb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17241 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
The datacenter was not being provided to a proxycfg query, which resulted in bypassing agentless query optimizations and using the normal API instead.
The health rpc endpoint would return a zero index when insufficient ACLs were detected. This would result in the agent cache performing an infinite loop of queries in rapid succession without backoff.
Overview of commits