-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug that wrongly trims domains when there is an overlap with DC name #17160
Merged
dhiaayachi
merged 16 commits into
hashicorp:main
from
shamil:fix_altdomain_dcname_overlap
Jun 26, 2023
Merged
Fix a bug that wrongly trims domains when there is an overlap with DC name #17160
dhiaayachi
merged 16 commits into
hashicorp:main
from
shamil:fix_altdomain_dcname_overlap
Jun 26, 2023
Commits on Apr 26, 2023
-
Fix a bug that wrongly trims domains when there is an overlap with DC…
… name Before this change, when DC name and domain/alt-domain overlap, the domain name incorrectly trimmed from the query. Example: Given: datacenter = dc-test, alt-domain = test.consul. Querying for "test-node.node.dc-test.consul" will faile, because the code was trimming "test.consul" instead of just ".consul" This change, fixes the issue by adding dot (.) before trimming
Configuration menu - View commit details
-
Copy full SHA for 74b15a6 - Browse repository at this point
Copy the full SHA 74b15a6View commit details
Commits on Apr 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6c866e - Browse repository at this point
Copy the full SHA b6c866eView commit details
Commits on Apr 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a1d0fa4 - Browse repository at this point
Copy the full SHA a1d0fa4View commit details
Commits on May 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d6fd5c3 - Browse repository at this point
Copy the full SHA d6fd5c3View commit details
Commits on May 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2c57d76 - Browse repository at this point
Copy the full SHA 2c57d76View commit details
Commits on May 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c738b39 - Browse repository at this point
Copy the full SHA c738b39View commit details
Commits on May 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b157426 - Browse repository at this point
Copy the full SHA b157426View commit details
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 10cef2d - Browse repository at this point
Copy the full SHA 10cef2dView commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 683a771 - Browse repository at this point
Copy the full SHA 683a771View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1d76b0 - Browse repository at this point
Copy the full SHA f1d76b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f5d0e - Browse repository at this point
Copy the full SHA 23f5d0eView commit details
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 585c57f - Browse repository at this point
Copy the full SHA 585c57fView commit details
Commits on Jun 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 737a06e - Browse repository at this point
Copy the full SHA 737a06eView commit details
Commits on Jun 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 17d7aef - Browse repository at this point
Copy the full SHA 17d7aefView commit details
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9e4e461 - Browse repository at this point
Copy the full SHA 9e4e461View commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c26ce0c - Browse repository at this point
Copy the full SHA c26ce0cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.