[CC-4519] Include Consul NodeID in Envoy bootstrap metadata #17139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being added so that metrics sent to HCP can be augmented with the source node's ID. Opting not to add this to stats_tag out of caution, since it would increase the cardinality of metrics emited by Envoy for all users. There is no functional impact to Envoy expected from this change.
freddygv
added
pr/no-changelog
freddygv
requested review from
a team,
erichaberkorn and
thisisnotashwin
and removed request for
a team
github-actions
bot
added
the
theme/cli
freddygv
added a commit
that referenced
this pull request
Apr 26, 2023
This is being added so that metrics sent to HCP can be augmented with the source node's ID. Opting not to add this to stats_tag out of caution, since it would increase the cardinality of metrics emitted by Envoy for all users. There is no functional impact to Envoy expected from this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is being added so that metrics sent to HCP can be augmented with the source node's ID.
Opting not to add this to stats_tag out of caution, since it would increase the cardinality of metrics emitted by Envoy for all users.
There is no functional impact to Envoy expected from this change.
Testing & Reproduction steps
Added unit tests and also did the following manual test:
Ran a single dev agent with
consul agent -devand registered the following service with a sidecar:{ "service": { "name": "counting", "port": 8181, "connect": { "sidecar_service": {} } } }Ran Envoy:
Compared the node ID in Envoy's config to the ID in the catalog:
PR Checklist