Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "cache: refactor agent cache fetching to prevent unnecessary f… #16818

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Revert "cache: refactor agent cache fetching to prevent unnecessary f… #16818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b19e610
Revert "cache: refactor agent cache fetching to prevent unnecessary f…
hashi-derek Mar 30, 2023
14c50c1
Add changelog entry.
hashi-derek Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .changelog/14956.txt
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4819,19 +4819,19 @@ services {

deadlineCh := time.After(10 * time.Second)
start := time.Now()
LOOP:
for {
select {
case evt := <-ch:
// We may receive several notifications of an error until we get the
// first successful reply.
require.Equal(t, "foo", evt.CorrelationID)
if evt.Err == nil {
require.NoError(t, evt.Err)
require.NotNil(t, evt.Result)
t.Logf("took %s to get first success", time.Since(start))
return
if evt.Err != nil {
break LOOP
}
t.Logf("saw error: %v", evt.Err)
require.NoError(t, evt.Err)
require.NotNil(t, evt.Result)
t.Logf("took %s to get first success", time.Since(start))
case <-deadlineCh:
t.Fatal("did not get notified successfully")
}
Expand Down
Loading