Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Fix struct tags for TCPService enterprise meta into release/1.15.x #16787

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Backport of Fix struct tags for TCPService enterprise meta into release/1.15.x #16787

merged 2 commits into from
Mar 27, 2023

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16781 to be assessed for backporting due to the inclusion of the label backport/1.15.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: unable to process merge commit: "e5ac37d47d3a1f4f087f2784df98b8978fee5a36", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.

Description

The TestAPIGatewayCreate enterprise tests are currently failing because of this missing struct tag

Testing & Reproduction steps

Run the TestAPIGatewayCreate tests on the ent repo

Links

N/A

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jm96441n/fix-tcp-service-ent-meta-flatenning/constantly-nice-hedgehog branch from 5dfc44d to f06baa1 Compare March 27, 2023 16:17
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jm96441n/fix-tcp-service-ent-meta-flatenning/constantly-nice-hedgehog branch 2 times, most recently from 7959380 to 5bce917 Compare March 27, 2023 16:17
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Mar 27, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@jm96441n jm96441n marked this pull request as ready for review March 27, 2023 16:23
@jm96441n jm96441n enabled auto-merge (squash) March 27, 2023 16:24
@jm96441n jm96441n merged commit 1553036 into release/1.15.x Mar 27, 2023
@jm96441n jm96441n deleted the backport/jm96441n/fix-tcp-service-ent-meta-flatenning/constantly-nice-hedgehog branch March 27, 2023 18:54
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm96441n jm96441n jm96441n approved these changes

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @jm96441n @github-team-consul-core-pr-approver