Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change partition for peers in discovery chain targets #16770

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Change partition for peers in discovery chain targets #16770

merged 1 commit into from
Mar 24, 2023

Conversation

hashi-derek
Copy link
Member

Manual backport of: #16769

@hashi-derek
Change partition for peers in discovery chain targets
152d0c5 
This commit swaps the partition field to the local partition for
discovery chains targeting peers. Prior to this change, peer upstreams
would always use a value of default regardless of which partition they
exist in. This caused several issues in xds / proxycfg because of id
mismatches.

Some prior fixes were made to deal with one-off id mismatches that this
PR also cleans up, since they are no longer needed.
@hashi-derek hashi-derek changed the base branch from main to release/1.15.x March 24, 2023 19:52
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases labels Mar 24, 2023
@hashi-derek hashi-derek requested a review from rboyer March 24, 2023 20:12
@hashi-derek hashi-derek marked this pull request as ready for review March 24, 2023 20:12
@hashi-derek hashi-derek merged commit dfb7f71 into release/1.15.x Mar 24, 2023
@hashi-derek hashi-derek deleted the derekm/NET-3382/change-chain-partition-15 branch March 24, 2023 20:40
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashi-derek @rboyer