Backport of NET-2903 Normalize weight for http routes into release/1.15.x #16532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/net-2903-apigw-http-route-service-weight-0/rarely-trusted-vulture
branch
from
d8a3a08
to
3c0a363
Compare
hc-github-team-consul-core
force-pushed
the
backport/net-2903-apigw-http-route-service-weight-0/rarely-trusted-vulture
branch
from
30790d5
to
ac6f8f8
Compare
github-actions
bot
added
the
type/docs
github-team-consul-core-pr-approver
approved these changes
Mar 3, 2023
* NET-2903 Normalize weight for http routes * Update website/content/docs/connect/gateways/api-gateway/configuration/http-route.mdx Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
andrewstucki
deleted the
backport/net-2903-apigw-http-route-service-weight-0/rarely-trusted-vulture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16512 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
Currently, if the weight of an HTTPRoute Service is unspecified or set to 0, the service will not be properly setup to have traffic routed to it.
These changes normalize the weight of a service on an HTTPRoute. If the weight is not specified or is set to 0, it will be normalized to 1.
Testing & Reproduction steps
Start consul with changes from branch
Use this gist to setup HTTPRoute services that have no weight defined.
You should not see an error.
Links
This prevents the bug seen in this issue
PR Checklist
Overview of commits